fix: preserve surrounding text when evaluating dynamic variable paths - #1044
Open
hamza-0987 wants to merge 3 commits into
Open
fix: preserve surrounding text when evaluating dynamic variable paths#1044hamza-0987 wants to merge 3 commits into
hamza-0987 wants to merge 3 commits into
Conversation
hamza-0987
force-pushed
the
fix-dynamic-url-rendering
branch
from
August 8, 2026 13:25
39a6bf8 to
5a8c631
Compare
|
📌 Esta mensagem está tanto em português quanto em inglês (mais abaixo) — assim todo mundo consegue acompanhar! 🇧🇷 Português 👋 Olá! Este PR está obsoleto porque ficou aberto por 30 dias sem atividade. Remova o rótulo de stale ou comente, caso contrário ele será fechado em 15 dias. 🇬🇧 English Hey there! 👋 This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1007
The regex in StringEvaluator was capturing surrounding word characters as part of the match, causing them to be replaced along with the variable value.
For example, with would incorrectly render as instead of .
This fix constructs the variable expression from the regex groups () instead of using the full match, ensuring only the variable itself is replaced.