Skip to content

fix: propagate errors upon ipam failure and use lb zone instead of annotation #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nox-404 merged 1 commit into from
Jan 23, 2024
Merged

fix: propagate errors upon ipam failure and use lb zone instead of annotation #155

nox-404 merged 1 commit into from
Jan 23, 2024

Conversation

@nox-404
Copy link
Contributor

@nox-404 nox-404 commented Jan 23, 2024 •
edited
Loading

No description provided.

jtherin
jtherin approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@jtherin jtherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nox-404 nox-404 merged commit 60ea03b into scaleway:master Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtherin jtherin jtherin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nox-404 @jtherin