Skip to content

Breaking api changes happened, fixing python client #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanshi-scale merged 2 commits into from
Feb 1, 2022
Merged

Breaking api changes happened, fixing python client #207

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe4654e
breaking api changes happened, fixing python client
seanshi-scale Jan 29, 2022
f1b2c8f
make endpoint creation not break
seanshi-scale Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions nucleus/deploy/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,9 @@ def create_model_endpoint(
elif gpus > 0 and gpu_type is None:
raise ValueError("If nonzero gpus, must provide gpu_type")
resp = self.connection.post(payload, ENDPOINT_PATH)
endpoint_creation_task_id = resp[
"endpoint_id"
] # Serverside needs updating
endpoint_creation_task_id = resp.get(
"endpoint_creation_task_id", None
) # TODO probably throw on None
logger.info(
"Endpoint creation task id is %s", endpoint_creation_task_id
)
Expand All @@ -194,7 +194,7 @@ def list_model_bundles(self) -> List[ModelBundle]:
"""
resp = self.connection.get("model_bundle")
model_bundles = [
ModelBundle(name=item["bundle_name"]) for item in resp
ModelBundle(name=item["bundle_name"]) for item in resp["bundles"]
]
return model_bundles

Expand All @@ -209,7 +209,7 @@ def list_model_endpoints(self) -> List[AsyncModelEndpoint]:
resp = self.connection.get(ENDPOINT_PATH)
return [
AsyncModelEndpoint(endpoint_id=endpoint_id, client=self)
for endpoint_id in resp
for endpoint_id in resp["endpoints"]
]

def sync_request(self, endpoint_id: str, url: str) -> str:
Expand Down