HMI Python client - #203
Merged
seanshi-scale merged 98 commits intoJan 26, 2022
Merged
Conversation
Tianwei-She
reviewed
Jan 21, 2022
| # resp = self.connection.get("model_bundle") | ||
| raise NotImplementedError | ||
|
|
||
| def list_model_endpoints(self) -> List[AsyncModelEndpoint]: |
There was a problem hiding this comment.
nit - use consistent name: model_endpoint vs endpoint, model_bundle vs bundle
perhaps we should just delete all "model" since it's kind of meaningless?
yixu34
approved these changes
Jan 22, 2022
yixu34
left a comment
yixu34
left a comment
Member
There was a problem hiding this comment.
Once we get the pyspark <-> HMI integration working, I think it's OK to merge this. We can take another pass and address the outstanding comments and go over things in more detail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes https://github.com/scaleapi/nucleus-python-client/pull/107/commits