Skip to content

Alternative way to enable fill file path names in scalactic #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
saksmt wants to merge 1 commit into
base: 3.1.x
Choose a base branch
from
Open

Alternative way to enable fill file path names in scalactic #1795

saksmt wants to merge 1 commit into from

Conversation

@saksmt
Copy link

@saksmt saksmt commented Mar 18, 2020

Enabling this setting through environment variable isn't always available, so there is alternative way: property.

Example where it is not possible: bazel (and probably other monorepository build tools too)

P.S. Is there a way to backport this to 3.0.x?

@saksmt saksmt mentioned this pull request Mar 18, 2020
Closed
@saksmt saksmt force-pushed the feature/fill-file-pathnames-prop-toggle branch from 37f9fa8 to fc697aa Compare March 19, 2020 07:57
@cheeseng
Copy link
Contributor

cheeseng commented Jul 21, 2020

@cla-bot[bot] check

@cla-bot
Copy link

cla-bot bot commented Jul 21, 2020

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Kirill Saksin.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Jul 21, 2020

The cla-bot has been summoned, and re-checked this pull request!

@plinlor
Copy link
Contributor

plinlor commented Aug 8, 2020

@cla-bot[bot] check

@cla-bot
Copy link

cla-bot bot commented Aug 8, 2020

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Kirill Saksin.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Aug 8, 2020

The cla-bot has been summoned, and re-checked this pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saksmt @cheeseng @plinlor