-
Notifications
You must be signed in to change notification settings - Fork 677
feat(api-client): integrate operation page mutators #7251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 27b1ad5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Scalar Docs PreviewProject Commit Status Preview Updated (UTC): Nov 4, 2025, 7:47 PM To edit notification comments on pull requests, go to your Scalar project settings |
|
Cloudflare Preview for the API Client |
Scalar Components Snapshot Test ResultsDetails
|
Scalar References End to End Test ResultsDetails
Important These tests include snapshots that may need to be updated if there are intentional changes to the UI components. To update the snapshots run |
Scalar CDN Snapshot Diff ResultsDetails
Failed teststest/snapshots-cdn/snapshot.e2e.ts › Diff with CDN - Stripe Important These tests detect visual differences between the current PR and the latest CDN build which means they may be affected by other changes in They can help determine if the changes in the PR are causing any unexpected visual regressions but may be less helpful in isolating the exact cause. For more details see the readme. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, did not test, left a few comments but nothing blocking
packages/api-client/src/v2/blocks/scalar-address-bar-block/components/AddressBar.vue
Outdated
Show resolved
Hide resolved
packages/api-client/src/v2/blocks/scalar-address-bar-block/components/AddressBar.vue
Show resolved
Hide resolved
packages/api-client/src/v2/blocks/scalar-auth-selector-block/helpers/security-scheme.ts
Show resolved
Hide resolved
| /** TODO: remove once we migrate */ | ||
| environment: Environment | ||
| envVariables: EnvVariable[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are migrated, you can remove! use the new components from the v2 folder.
I just realized its on my branch LOL, once I merge you can get rid of the old env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank god now we can remove those 😂
packages/api-client/src/v2/blocks/scalar-operation-block/components/OperationTableRow.vue
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,187 @@ | |||
| <script setup lang="ts"> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is an operation container? Can we get top level jsdoc here? Or we end up with something like OperationRoot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is basically a dumb Operation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't came up with a better name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha just some docs explaining it is good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can call it OperationDumb 😆
Checklist
I've gone through the following:
pnpm changeset).Note
Moves operation and auth UIs to workspace event-bus with new workspace-store mutators and schema extensions, adds OperationContainer and routing, and updates tests and helpers.
OperationContainerand route;Header/AddressBaremitupdate:method/update:pathandimport:curl;OperationBlockemits event-bus actions for summary, parameters, and request body;ResponseBlockuses event bus for command palette and send.AuthSelector/RequestAuthDataTableswitch to event-bus (auth:update:*, delete) withmeta; preserve selected scopes.path,method,exampleName); sidebar item select expands.x-scalar-selected-security,x-scalar-selected-content-type, and operation identifiers (x-scalar-path,x-scalar-method).generateUniqueValue; harden proxy unpacking; export mutators and include in build.Written by Cursor Bugbot for commit 27b1ad5. This will update automatically on new commits. Configure here.