Skip to content

ci: consistent UUIDs, Blacksmith runner, script rename & caching #7244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

ci: consistent UUIDs, Blacksmith runner, script rename & caching #7244

wants to merge 8 commits into from
+4,470 −72

Conversation

@xC0dex
Copy link
Collaborator

@xC0dex xC0dex commented Nov 3, 2025 •
edited
Loading

This PR:

  • Removes CI=1 occurrences as the CI variable is always true.
  • Uses a single, consistent approach for generating UUIDs instead of multiple methods.
  • Updates a recently added job to run with the Blacksmith runner.
  • Rename standalone.js to scalar.js before uploading the artifact.
  • Caching for Maven and NuGet dependencies.

Checklist

I've gone through the following:

  • I've added an explanation why this change is needed.
  • I've added a changeset (pnpm changeset).
  • I've added tests for the regression or new feature.
  • I've updated the documentation.

Note

Renames and standardizes the JS artifact to scalar.js, unifies UUID generation with uuidgen, and adds NuGet/Maven caching and lockfiles with related CI updates across Docker, .NET, Rust, and Java pipelines.

  • CI workflow (.github/workflows/ci.yml):
    • Artifact standardization:
      • Replace standalone.js with scalar.js (copy + upload) and update all download/paths in docker, .NET, rust, and java-webjar jobs.
      • Compress scalar.js where applicable.
    • UUID generation: Use uuidgen consistently for DEPLOY_ID across jobs.
    • Runners: Switch “Required CI OK” to blacksmith-2vcpu-ubuntu-2204.
    • Java (WebJar): Use Maven (mvn) for test/build/publish; enable actions/setup-java cache.
    • .NET: Enable actions/setup-dotnet caching with lockfiles; set NUGET_PACKAGES and use artifact scalar.js in packaging workflows.
  • .NET repo config:
    • integrations/dotnet/Directory.Build.props: Enable RestorePackagesWithLockFile and locked mode in CI.
    • Add packages.lock.json across .NET projects/tests to support deterministic restore and caching.
  • Tooling:
    • biome.json: Exclude packages.lock.json from processing.

Written by Cursor Bugbot for commit 5b32d66. Configure here.

@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8120bfb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025 •
edited
Loading

Preview Examples

https://78cf5c39-2884-48ee-9479-64af220ccbad--scalar-deploy-preview.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025 •
edited
Loading

Preview Storybook

https://cd6b2db2-cc00-4d39-bce2-1f14e35f9254--scalar-components.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025 •
edited
Loading

Scalar References End to End Test Results

passed  66 passed

Details

report  Open report ↗︎
stats  66 tests across 30 suites
duration  17.9 seconds
commit  8120bfb

Important

These tests include snapshots that may need to be updated if there are intentional changes to the UI components. To update the snapshots run pnpm test:e2e:update in packages/api-reference and commit the changes.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025 •
edited
Loading

Scalar Components Snapshot Test Results

passed  152 passed

Details

report  Open report ↗︎
stats  152 tests across 19 suites
duration  45.4 seconds
commit  8120bfb

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025 •
edited
Loading

Scalar CDN Snapshot Diff Results

failed  1 failed
passed  19 passed

Details

report  Open report ↗︎
stats  20 tests across 1 suite
duration  33.5 seconds
commit  8120bfb
info  These tests are non-blocking and will not prevent merging of your PR.

Failed tests

test/snapshots-cdn/snapshot.e2e.ts › Diff with CDN - Stripe

Important

These tests detect visual differences between the current PR and the latest CDN build which means they may be affected by other changes in main that haven't been released yet.

They can help determine if the changes in the PR are causing any unexpected visual regressions but may be less helpful in isolating the exact cause. For more details see the readme.

@xC0dex xC0dex force-pushed the ci/improvements branch 2 times, most recently from 70325ce to 5b32d66 Compare November 3, 2025 17:48
@xC0dex xC0dex changed the title ci: small improvements ci: consistent UUIDs, Blacksmith runner, script rename & caching Nov 3, 2025
@xC0dex xC0dex marked this pull request as ready for review November 3, 2025 18:23
cursor[bot]
cursor bot reviewed Nov 3, 2025
View reviewed changes
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Version Extraction Missing for Maven Publish Job

The java-webjar-publish job's "Set version in pom.xml" step uses an undefined $VERSION environment variable for the mvn versions:set command. This job is missing the step to extract the version from package.json and set it as an environment variable, which other publish jobs include. This causes the Maven command to fail.

.github/workflows/ci.yml#L1323-L1327

scalar/.github/workflows/ci.yml

Lines 1323 to 1327 in 5b32d66

- if: steps.changed-files.outputs.java_webjar_package_any_changed == 'true'
name: Set version in pom.xml (using the version from package.json)
working-directory: integrations/java/webjar
run: mvn versions:set -DnewVersion=$VERSION -DgenerateBackupPoms=false
- if: steps.changed-files.outputs.java_webjar_package_any_changed == 'true'

Fix in Cursor Fix in Web

@xC0dex xC0dex force-pushed the ci/improvements branch 3 times, most recently from d1a9b8c to 16c5301 Compare November 4, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@marclave marclave Awaiting requested review from marclave marclave is a code owner

@hanspagel hanspagel Awaiting requested review from hanspagel hanspagel is a code owner

@geoffgscott geoffgscott Awaiting requested review from geoffgscott geoffgscott is a code owner

@amritk amritk Awaiting requested review from amritk amritk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xC0dex