docs: document icon-dark #7237
docs: document icon-dark #7237
Conversation
jpjpjp
requested review from
amritk,
geoffgscott,
hanspagel and
marclave
as code owners
|
There was a problem hiding this comment.
you’re right, thanks!
can we use the following URLs for the logo?
https://cdn.scalar.com/images/logo-dark.svg
https://cdn.scalar.com/images/logo-light.svg
the other one will go away soon
hanspagel
force-pushed
the
document_image_dark
branch
from
8291217 to
e48555a
Compare
no problem. Finding a logo to use actually took 10 times longer than creating this PR. 🤣 glad you know a good one @hanspagel Hmmm...when I make this change locally icon-dark seems to be pulling in the wrong logo: 
When I revert to the original version I committed, it works as expected: |
2 participants
Problem
Currently, the buttons documentation does not describe the image-dark property. When viewing this page in light mode, you cannot see the scalar icon that is added to the button in the last example
Solution
With this PR, we include icon-dark as an optional property in the properties documentation and update the example to show a button with both light and dark images.
Checklist
I've gone through the following:
pnpm changeset).Note
Adds
icon-darkas an optional button prop and updates the external icon example to demonstrate light/dark icons.documentation/guides/docs/components/buttons.md):icon-darkoptional prop to the Properties section with description.icon(light) andicon-dark(dark), adjusting example values across HTML and directive snippets.Written by Cursor Bugbot for commit e48555a. This will update automatically on new commits. Configure here.