chore: add knip
#7233
Open
chore: add knip
#7233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1ddf877 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marcalexiei
force-pushed
the
knip
branch
2 times, most recently
from
85f86a0 to
8b9c0a0
Compare
marcalexiei
commented
Nov 2, 2025
marcalexiei
requested review from
amritk,
geoffgscott,
hanspagel and
marclave
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
marcalexiei
commented
Nov 2, 2025
4 tasks
hanspagel
approved these changes
Nov 3, 2025
This comment was marked as outdated.
This comment was marked as outdated.
|
Ah, sorry, we don't need to add it to the "needs" array everywhere, we can just add it to the required checks, that’s enough I‘d say. |
|
Now |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
N/A
Solution
This PR is a small proof of concept to try out Knip on this repository.
Currently, it includes analysis for the following packages and files:
package.jsonscriptsintegrations/docusaurusintegrations/fastifycustomThemefromfastifyApiReference.ts.It was an empty string and wasn't exported from the package entry point so it wasn't part of the public API.
packages/mock-serverAlthough this PR introduces only a few changes,
it should provide a good initial sense of how Knip can help improve and maintain the project over time.
E.g.,
My plan is to proceed gradually with additional PRs to expand coverage.
Let me know what you think about this. Thanks!
Checklist
I've gone through the following:
pnpm changeset).Note
Adds Knip with CI integration and config, cleans unused code/deps, and removes the unused customTheme from fastify with a related test update.
knip.jsonc) and CI job (knip) withpnpm lint:knip; gaterequired-ci-okon it.knipin rootpackage.json; addlint:knipscript..syncpackrc.customThemeand stop passing it togetHtmlDocumentinfastifyApiReference.ts.vi; assert warning when no spec source is provided.stdout-updatedependency and the spinner output module (scripts/src/commands/output.ts).integrations/docusaurusdev script fix; add@scalar/build-tooling).@scalar/mock-serverand its playground.turbo.jsonschema to local path.pnpm-workspace.yamlcatalogs (removestdout-update).Written by Cursor Bugbot for commit 1ddf877. This will update automatically on new commits. Configure here.