Skip to content

fix(api-client): remove form data binary default file #7069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(api-client): remove form data binary default file #7069

wants to merge 2 commits into from

Conversation

@OdujokoD
Copy link

@OdujokoD OdujokoD commented Oct 13, 2025

Problem
Currently, when a string parameter of the request body for a Form URL Encoded has a binary format, a default file is returned requiring the user to delete that file before uploading another as described in #6817

Solution

With this PR, the default file has been removed allowing a direct file upload
Screenshot 2025-10-13 at 8 21 13 AM
s now been removed allowing a direct upload of a file

Checklist

I've gone through the following:

  • I've added an explanation why this change is needed.
  • I've added a changeset (pnpm changeset).
  • I've added tests for the regression or new feature.
  • I've updated the documentation.

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: dc4011d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OdujokoD
Copy link
Author

OdujokoD commented Oct 13, 2025

Hey @hanspagel @amritk , I'd love feedback on this before switching to a completed PR, particularly around the TODO comments I left:

  • The handleFileUploadFormData in the RequestBody component maintains the initial value (or example) set in the spec and doesn't change to the uploaded file name. Should this be fixed in this PR or raised as a separate issue?
  • Should the check for the binary format be totally removed since the check is currently redundant or is there something else being consider for binary formats?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amritk amritk Awaiting requested review from amritk amritk will be requested when the pull request is marked ready for review amritk is a code owner

@hanspagel hanspagel Awaiting requested review from hanspagel hanspagel will be requested when the pull request is marked ready for review hanspagel is a code owner

@marclave marclave Awaiting requested review from marclave marclave will be requested when the pull request is marked ready for review marclave is a code owner

@DemonHa DemonHa Awaiting requested review from DemonHa DemonHa will be requested when the pull request is marked ready for review DemonHa is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@OdujokoD