REPL: Add compiler options to :reset #14139
Conversation
dwijnand
force-pushed
the
repl/reset-with-opts
branch
from
e8b973c to
a43cf75
Compare
SethTisue
left a comment
SethTisue
left a comment
There was a problem hiding this comment.
should these be revived? removed?
tests/disabled/partest/run/repl-reset.check:scala> :reset
tests/disabled/partest/run/repl-reset.scala: |:reset
tests/disabled/partest/run/t7747-repl.check:scala> :reset
tests/disabled/partest/run/t7747-repl.scala: |:reset
| |:imports show import history | ||
| |:reset reset the repl to its initial state, forgetting all session entries | ||
| |:reset [options] reset the repl to its initial state, forgetting all session entries | ||
| |:settings <options> update compiler options, if possible |
There was a problem hiding this comment.
nitpick: I think you meant angle brackets here, like the other entries?
There was a problem hiding this comment.
it's a type parameter, not an index.
There was a problem hiding this comment.
I copied Scala 2. And I think I kind of grok the logic there to be <options> for settings, because it's expected to get options, even though it actually accepts none as a way to print options... While for :reset (and :replay in the scala 2 repl) passing options is more of an extra, so more... optional (🥁 !)
Or we can deviate to fix it to some standard. I just looked at http://docopt.org/ before realising I wasn't following that here, I was following what Scala 2 had.
There was a problem hiding this comment.
Personally I think it should follow docopt, but it's not a blocker.
dwijnand
force-pushed
the
repl/reset-with-opts
branch
from
a43cf75 to
11b9e3c
Compare
dwijnand
force-pushed
the
repl/reset-with-opts
branch
from
11b9e3c to
4902a68
Compare
|
The main impl landed in #14140. |
3 participants
An easy change that makes it match Scala 2's REPL.