Skip to content

Commit cdb519c

Browse files
committed
fix: removed "prerender" token from builder if using custom URL
Signed-off-by: Martin <martin@hotmail.com.br>
1 parent 215a291 commit cdb519c

File tree

2 files changed

+11
-15
lines changed

2 files changed

+11
-15
lines changed

src/builder.rs

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ use url::Url;
3535
/// use actix_web::http::header;
3636
///
3737
/// let token = "prerender service token".to_string();
38-
/// let prerender = Prerender::build().use_custom_prerender_url("https://localhost:5001", token);
38+
/// let prerender = Prerender::build().use_custom_prerender_url("https://localhost:5001");
3939
///
4040
/// // `prerender` can now be used in `App::wrap`.
4141
/// ```
@@ -52,23 +52,19 @@ impl PrerenderBuilder {
5252
let inner = Inner {
5353
prerender_service_url: middleware::prerender_url(),
5454
inner_client: Client::default(),
55-
prerender_token: token,
55+
prerender_token: Some(token),
5656
};
5757

5858
Prerender { inner: Rc::new(inner) }
5959
}
6060

61-
pub fn use_custom_prerender_url(
62-
self,
63-
prerender_service_url: &str,
64-
token: String,
65-
) -> Result<Prerender, PrerenderError> {
61+
pub fn use_custom_prerender_url(self, prerender_service_url: &str) -> Result<Prerender, PrerenderError> {
6662
let prerender_service_url = Url::parse(prerender_service_url).map_err(|_| PrerenderError::InvalidUrl)?;
6763

6864
let inner = Inner {
6965
prerender_service_url,
7066
inner_client: Client::default(),
71-
prerender_token: token,
67+
prerender_token: None,
7268
};
7369

7470
Ok(Prerender { inner: Rc::new(inner) })

src/middleware.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ use actix_web::http::{header, Method};
99
use actix_web::{Error, HttpResponse};
1010
use futures_util::future::LocalBoxFuture;
1111
use futures_util::TryFutureExt;
12-
use log::debug;
12+
use log::trace;
1313
use reqwest::Client;
1414
use url::Url;
1515

@@ -20,7 +20,7 @@ use crate::{IGNORED_EXTENSIONS, USER_AGENTS};
2020
pub struct Inner {
2121
pub(crate) prerender_service_url: Url,
2222
pub(crate) inner_client: Client,
23-
pub(crate) prerender_token: String,
23+
pub(crate) prerender_token: Option<String>,
2424
}
2525

2626
pub(crate) fn prerender_url() -> Url {
@@ -105,14 +105,14 @@ impl<S> PrerenderMiddleware<S> {
105105
}
106106

107107
prerender_request_headers.append(header::ACCEPT_ENCODING, "gzip".parse().unwrap());
108-
prerender_request_headers.append(
109-
"X-Prerender-Token".parse().unwrap(),
110-
inner.prerender_token.parse().unwrap(),
111-
);
108+
109+
if let Some(token) = &inner.prerender_token {
110+
prerender_request_headers.append("X-Prerender-Token".parse().unwrap(), token.parse().unwrap());
111+
}
112112

113113
let url_to_request = Self::prepare_build_api_url(&inner.prerender_service_url, &req);
114114

115-
debug!("sending request to: {}", &url_to_request);
115+
trace!("sending request to: {}", &url_to_request);
116116
let prerender_response = inner
117117
.inner_client
118118
.get(url_to_request)

0 commit comments

Comments
 (0)