Skip to content

Migrate Interface to Kotlin#2

Open
sarahcodes100 wants to merge 1 commit intoadd-kotlin-pluginfrom
kotlin-example-source
Open

Migrate Interface to Kotlin#2
sarahcodes100 wants to merge 1 commit intoadd-kotlin-pluginfrom
kotlin-example-source

Conversation

@sarahcodes100
Copy link
Copy Markdown
Owner

What

Converts DeviceListener.java -> DeviceListener.kt

Why

We are incrementally migrating the repository to Kotlin

How

  • Use Intellij's conversion tool:

1

- Verify that the `trace: List` parameter should in fact be non-null (and other gotchas from converting don't exist)

Test

To test this, I:

  • Added logs to AndroidRunner (the class that implements this interface)
  • Built the mode with./gradlew dist
  • Unzipped the generated AndroidMode.zip into Documents/Processing/modes/AndroidMode
  • Opened an example Sketch
  • Ran it on my device
  • Verified that my logs were present and the interface was working as before

@sarahcodes100 sarahcodes100 changed the title migrate interface to kotlin Migrate Interface to Kotlin May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant