Fixed bug where trying to get a key from a velocypack array would crash the driver

martin-schilling · martin-schilling · commit b52f9c30cea7 · 2017-12-10T14:26:16.000+01:00
diff --git a/src/connection.cpp b/src/connection.cpp
@@ -113,9 +113,20 @@ namespace arangodb { namespace fuerte { namespace php {
 
         auto response = new Response(*result);
 
+        bool failure = false;
+        if(response->getFuerteResponse()->slices().front().isObject()) {
+            failure = response->getFuerteResponse()->slices().front().get("error").getBool();
+        }
+
         auto statusCode = response->getHttpCode();
-        if((!(statusCode >= 200 && statusCode <= 299))/* || response->getFuerteResponse()->slices().front().get("error").getBool()*/) {
-            throwRequestFailedException("This is the error message", statusCode, response->getBody());
+        if((!(statusCode >= 200 && statusCode <= 299)) || failure) {
+            std::string errorMessage = "Response contains an error";
+
+            if(response->getFuerteResponse()->slices().front().isObject()) {
+                errorMessage = response->getFuerteResponse()->slices().front().get("errorMessage").copyString();
+            }
+
+            throwRequestFailedException(errorMessage.c_str(), statusCode, response->getBody());
         }
 
         return response;
