Improve unit tests

sandrokeil · sandrokeil · commit 3a72d5af351b · 2017-12-10T09:34:43.000+01:00
diff --git a/docker-compose.yml b/docker-compose.yml
@@ -28,7 +28,7 @@ services:
     command: ["vendor/bin/phpunit"]
 
   arangodb:
-    image: arangodb:3.2
+    image: arangodb:3.2.9
     ports:
       - 8529:8529
     environment:
diff --git a/tests/ConnectionTest.php b/tests/ConnectionTest.php
@@ -24,6 +24,8 @@ public function tearDown()
     {
         if ($this->connection) {
             TestUtil::deleteCollection($this->connection, 'event_streams');
+            TestUtil::deleteCollection($this->connection, 'c6f955fd5efbc2cedbb5f97cfd8890bb98b364c1d');
+            TestUtil::deleteCollection($this->connection, 'request_failed_exception_test');
         }
     }
 
@@ -152,6 +154,7 @@ public function it_sends_large_request_via_post()
         $body = json_decode($response->getBody(), true);
 
         $this->assertNotNull($body);
+        $this->assertFalse($body['error']);
         $this->assertTrue(TestUtil::wasSuccessful($response), var_export($body, true));
     }
 
@@ -397,11 +400,12 @@ public function it_throws_request_failed_exception_with_response_data()
             $this->assertTrue(false);
 
         } catch(\ArangoDb\RequestFailedException $e) {
-            $this->assertNotNull($e->getCode());
-            $this->assertNotNull($e->getHttpCode());
+            $this->assertSame(409, $e->getCode());
+            $this->assertSame(409, $e->getHttpCode());
             $this->assertTrue($e->getCode() === $e->getHttpCode());
             $this->assertJson($e->getBody());
             $this->assertTrue(json_decode($e->getBody(), true)['errorMessage'] === 'duplicate name');
+            $this->assertSame('duplicate name', $e->getMessage());
         }
     }
 }
diff --git a/tests/ExceptionTest.php b/tests/ExceptionTest.php
@@ -8,7 +8,7 @@
 use ArangoDb\Connection;
 
 /**
- * @group connection
+ * @group exception
  */
 class ExceptionTest extends TestCase
 {
diff --git a/tests/TestUtil.php b/tests/TestUtil.php
@@ -58,7 +58,7 @@ public static function getVpackCreateCollection(string $collectionName): Vpack
         return Vpack::fromArray([
             'name' => $collectionName,
             'keyOptions' => [
-                'allowUserKeys' => false,
+                'allowUserKeys' => true,
                 'type' => 'autoincrement',
                 'increment' => 1,
                 'offset' => 1,

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,8 @@ public function tearDown()`
`24`	`24`	`{`
`25`	`25`	`if ($this->connection) {`
`26`	`26`	`TestUtil::deleteCollection($this->connection, 'event_streams');`
	`27`	`+ TestUtil::deleteCollection($this->connection, 'c6f955fd5efbc2cedbb5f97cfd8890bb98b364c1d');`
	`28`	`+ TestUtil::deleteCollection($this->connection, 'request_failed_exception_test');`
`27`	`29`	`}`
`28`	`30`	`}`
`29`	`31`
`@@ -152,6 +154,7 @@ public function it_sends_large_request_via_post()`
`152`	`154`	`$body = json_decode($response->getBody(), true);`
`153`	`155`
`154`	`156`	`$this->assertNotNull($body);`
	`157`	`+ $this->assertFalse($body['error']);`
`155`	`158`	`$this->assertTrue(TestUtil::wasSuccessful($response), var_export($body, true));`
`156`	`159`	`}`
`157`	`160`
`@@ -397,11 +400,12 @@ public function it_throws_request_failed_exception_with_response_data()`
`397`	`400`	`$this->assertTrue(false);`
`398`	`401`
`399`	`402`	`} catch(\ArangoDb\RequestFailedException $e) {`
`400`		`- $this->assertNotNull($e->getCode());`
`401`		`- $this->assertNotNull($e->getHttpCode());`
	`403`	`+ $this->assertSame(409, $e->getCode());`
	`404`	`+ $this->assertSame(409, $e->getHttpCode());`
`402`	`405`	`$this->assertTrue($e->getCode() === $e->getHttpCode());`
`403`	`406`	`$this->assertJson($e->getBody());`
`404`	`407`	`$this->assertTrue(json_decode($e->getBody(), true)['errorMessage'] === 'duplicate name');`
	`408`	`+ $this->assertSame('duplicate name', $e->getMessage());`
`405`	`409`	`}`
`406`	`410`	`}`
`407`	`411`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`use ArangoDb\Connection;`
`9`	`9`
`10`	`10`	`/**`
`11`		`- * @group connection`
	`11`	`+ * @group exception`
`12`	`12`	`*/`
`13`	`13`	`class ExceptionTest extends TestCase`
`14`	`14`	`{`