change of scheme for rubyReserve. #235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a real ruby with real characters, but ensure it has no width and is not visible. Add it before other content on the line. For 'both' add two. This works for Chrome and Firefox.
palemieux
requested changes
Oct 11, 2022
Contributor
palemieux
left a comment
palemieux
left a comment
There was a problem hiding this comment.
Can you provide a test file and open an issue?
Contributor
Author
|
please compare existing tests in Chrome and Firefox. |
Contributor
Author
|
also addresses #236 |
Contributor
|
@btsimonh I think this is a Chrome bug |
Contributor
Author
|
irrespective, the proposed scheme works in both Chrome and Firefox. I'm not sure if the browsers even considered such things as reserving space for rubies.... :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a real ruby with real characters, but ensure it has no width and is not visible.
Add it before other content on the line. For 'both' add two, one for above, and one for below.
This works for Chrome and Firefox.
Note: the browser detection has been disabled but not removed. -webkit should no longer be required, and firefox and chrome seem to have similar behaviour now.
I spent a lot of time examining position of text with and without rubies. The addition of 'fake' rubies may not be the best way to go - using margin/padding may be better? I think the browser implementations are still young...