Repository navigation
Conversation
The ``gitfs_remotes`` fileserver already accepts a 40-char hex SHA (or short SHA) as its base ref, but ``ext_pillar: git`` rejected the same input with "remote ref does not exist" because ``GitPython.checkout`` and ``Pygit2.checkout`` only tried ``origin/<ref>`` and ``tags/<ref>``. Both providers now fall back to resolving a hex ref as a commit SHA (matching the ``get_tree_from_sha`` branch already used by the gitfs read path). The config shape is unchanged — existing branch/tag inputs behave exactly as before. Fixes saltstack#64199.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64199.
Fix lands in
salt/utils/gitfs.py— adds a SHA fallback toGitPython.checkoutandPygit2.checkoutso a hex ref (full or short) resolves to that commit, matching the behaviorgitfs_remotesalready provides.