fix various bugs in list_present #68369
Open
+147
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sxderp
force-pushed
the
pr-fix-list-preset-duplicates
branch
from
1959920 to
e8d0d98
Compare
3 tasks
Sxderp
force-pushed
the
pr-fix-list-preset-duplicates
branch
from
e8d0d98 to
651972e
Compare
Sxderp
force-pushed
the
pr-fix-list-preset-duplicates
branch
from
651972e to
31504ee
Compare
twangboy
requested changes
Oct 6, 2025
This was
linked to
issues
Oct 6, 2025
|
rebase on 3007.x |
twangboy
approved these changes
Oct 31, 2025
fixes saltstack#31427 fixes saltstack#39875 (previous solution was incomplete) Trying to convert the list and sub-objects into a set caused various issues when checking for existance. Use a proper loop and `in` checks to provide a more correct behavior.
Sxderp
force-pushed
the
pr-fix-list-preset-duplicates
branch
from
0c26b5f to
9931f05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #31427
fixes #39875 (previous solution was incomplete)
Trying to convert the list and sub-objects into a set caused various issues when checking for existance. Use a proper loop and
inchecks to provide a more correct behavior.What does this PR do?
Fixes some bugs in the grains.list_present state. Some potential performance is lost (no measurements or benchmarks made) in favor of correctness. Out of the newly added test the previous implementation only "passed" the "test_list_present_multiple_calls_present_as_list" test. New implementation passes all the new tests.
What issues does this PR fix or reference?
fixes #31427
fixes #39875 (previous solution was incomplete)
Previous Behavior
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No