feat: allow npm for publish and install #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iowillhoit
reviewed
Jul 23, 2025
.github/workflows/npmPublish.yml
Outdated
| id: is-published | ||
| run: | | ||
| RESPONSE=$(npm view .@$INPUTS_GITHUB_TAG version --json --silent || echo "Not published") | ||
| RESPONSE=$(npm view .@${{ inputs.githubTag }} version --json --silent || echo "Not published") |
Contributor
There was a problem hiding this comment.
Can you change this back to use an env var? Looks like this needs to be reverted in several places. This is a convention we use to prevent RCE
iowillhoit
reviewed
Jul 23, 2025
.github/workflows/npmPublish.yml
Outdated
|
|
||
| - name: Validate package manager | ||
| run: | | ||
| if [[ "${{ inputs.packageManager }}" != "yarn" && "${{ inputs.packageManager }}" != "npm" ]]; then |
Contributor
There was a problem hiding this comment.
Move packageManager to an env var
iowillhoit
reviewed
Jul 23, 2025
| runs-on: ubuntu-latest | ||
| env: | ||
| INPUTS_GITHUB_TAG: ${{ inputs.githubTag }} | ||
| INPUTS_PACKAGE_MANAGER: ${{ inputs.packageManager }} |
Contributor
There was a problem hiding this comment.
Nice, good idea to move these (non-secret envs) to the top level.
iowillhoit
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some repos that use npm (jsforce, most of vscode ext) use npm, not yarn.
but they'd like to use the shared publish stuff.