fix(observable): clarify next-only subscribe errors - #285
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #285 +/- ##
==========================================
+ Coverage 82.47% 82.72% +0.25%
==========================================
Files 84 84
Lines 11887 12246 +359
==========================================
+ Hits 9804 10131 +327
- Misses 2083 2115 +32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
M-Adoo
enabled auto-merge
September 1, 2026 23:15
M-Adoo
force-pushed
the
fix/fallible-subscribe-diagnostics
branch
from
September 2, 2026 01:47
3bd8859 to
bc5f4dc
Compare
Require next-only subscriptions to use infallible observables, provide guidance to handle errors with `.on_error(...)`, and hide the generic observer forwarding implementation from diagnostics. Mark `OnError` results as infallible and add regression coverage.
M-Adoo
force-pushed
the
fix/fallible-subscribe-diagnostics
branch
from
September 2, 2026 02:08
bc5f4dc to
1d036f4
Compare
wjian23
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.on_error(...).OnErrorresults as infallible and adds regression coverage.