chore: rm scheduler field from Retry - #282
Merged
M-Adoo merged 1 commit intoJul 13, 2026
Merged
Conversation
mightyiam
marked this pull request as ready for review
July 11, 2026 09:51
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #282 +/- ##
==========================================
+ Coverage 82.38% 82.47% +0.09%
==========================================
Files 84 84
Lines 11791 11887 +96
==========================================
+ Hits 9714 9804 +90
- Misses 2077 2083 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
M-Adoo
enabled auto-merge
July 12, 2026 00:14
wjian23
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, while studying towards
catch_errorwe noticed that this field can be removed andcargo teststill passes.We understand that a scheduler performs effects. Scheduling tasks.
So we kind of expect you to tell us that yes, it needs to be kept alive within this field and that this success is a race condition.
We also noticed such fields in
DelayandDebounce, which makes sense.But if that's the case, can these fields have test coverage?