trivial failing test case for non-existing catch_error operator - #281
trivial failing test case for non-existing catch_error operator#281mightyiam wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #281 +/- ##
==========================================
- Coverage 82.43% 82.38% -0.05%
==========================================
Files 84 84
Lines 11810 11816 +6
==========================================
Hits 9735 9735
- Misses 2075 2081 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for opening this. For the implementation, For the first version, I think it is fine to keep the semantics simple: source values pass through, source completion completes normally, source error calls the handler and switches to the fallback observable. The fallback should then forward its values/completion/error downstream. |
|
Thank you for responding! Looking at |
|
Hey. Just an update report. I know that this is only one operator, but it has been quite a challenge, and it seems we have made progress. |
|
I think we have it nearly figured out today. |
d354d2d to
698db13
Compare
|
Still coming along. |
Co-authored-by: shivaraj-bh <me@shivaraj-bh.in>
698db13 to
f53bd8d
Compare
Hey, this is a very low effort, even a non-contribution, especially since the absence of
catch_erroris recognized:rxRust/missing_features.md
Line 98 in 528b298
Is anyone implementing
catch_erroor planning to implement it?I would like to think that I can do it, but I am concerned that there might be a "good" reason it's not implemented yet and that the reason is that it's not easy and might require some prior complex refactoring. But I'm just contemplating. What do you maintainers think? Can/should a user look into this?
Co-authored-by: shivaraj-bh me@shivaraj-bh.in