Skip to content

fix: support into_future on shared observable pipelines - #277

Merged
wjian23 merged 1 commit into
masterfrom
fix/issue-276-into-future-shared
May 5, 2026
Merged

wjian23 merged 1 commit into
masterfrom
fix/issue-276-into-future-shared

Conversation

@M-Adoo

@M-Adoo M-Adoo commented May 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • make into_future() use the observable context's shared handle instead of hard-coded Rc<RefCell<_>>
  • keep the public return type concrete via ObservableFutureOf while allowing Local/Shared contexts to choose the backing handle
  • add regression coverage for observe_on(SharedScheduler) and the BehaviorSubject reproduction from issue Can't seem to use into_future for Observable built from Subject #276

Closes #276

@codecov

codecov Bot commented May 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.45%. Comparing base (3f725c9) to head (fe26cb2).

Files with missing lines Patch % Lines
src/ops/into_future.rs 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
- Coverage   82.84%   82.45%   -0.40%     
==========================================
  Files          84       84              
  Lines       12196    11776     -420     
==========================================
- Hits        10104     9710     -394     
+ Misses       2092     2066      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@M-Adoo
M-Adoo force-pushed the fix/issue-276-into-future-shared branch from 890a65a to fe26cb2 Compare May 5, 2026 11:00
@wjian23
wjian23 enabled auto-merge May 5, 2026 12:20
@wjian23
wjian23 disabled auto-merge May 5, 2026 12:21
@wjian23
wjian23 merged commit b81049b into master May 5, 2026
11 of 12 checks passed
@wjian23
wjian23 deleted the fix/issue-276-into-future-shared branch May 5, 2026 12:21
@aponyrko

aponyrko commented May 8, 2026

Copy link
Copy Markdown

Thanks for fixing this! Would it be possible to publish rc5 to crates.io?

@M-Adoo

M-Adoo commented May 8, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks for fixing this! Would it be possible to publish rc5 to crates.io?

https://crates.io/crates/rxrust/1.0.0-rc.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't seem to use into_future for Observable built from Subject

3 participants