feat: add signal method overloads to select nested keys #1662
+123
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
{ } State
edbzn
reviewed
Dec 24, 2023
| return new Proxy<SignalStateProxy<State>>(signalState, { | ||
| get<K extends keyof State>( | ||
| target: SignalStateProxy<State>, | ||
| p: K | string | symbol |
There was a problem hiding this comment.
Why removing the generic and union type here?
| export function createSignalStateProxy<State extends object>( | ||
| state$: Observable<State>, | ||
| stateFn: <K extends keyof State>(k: K) => State[K] | ||
| stateFn: RxState<State>['get'] |
There was a problem hiding this comment.
Could you explain the type change here? I'm not sure why stateFn becomes type of RxState.get
| /** | ||
| * @internal | ||
| */ | ||
| signal<R>(...args: string[]): Signal<R> { |
There was a problem hiding this comment.
What about naming it keys instead of args?
| target[key] = _signal; | ||
| state$ | ||
| .pipe(select(p as K), takeUntilDestroyed(destroyRef)) | ||
| .pipe(select(...(keyFields as [any])), takeUntilDestroyed(destroyRef)) |
There was a problem hiding this comment.
Not sure why we dropped the generic cast in favor of [any]?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables signal method overloads 🚀
I went with this approach:
TODO: add docs
Fixes #1659
cc @hoebbelsB @edbzn