Skip to content

Conversation

@BioPhoton
Copy link
Member

No description provided.

@nx-cloud
Copy link

nx-cloud bot commented Feb 3, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0b1bda8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx affected:test --parallel --maxParallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@github-actions github-actions bot added { } State @rx-angular/state related 📖 Docs API Documentation in the source code 🛂 Test Unit tests, e2e tests, integration tests, test coverage labels Feb 3, 2022
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
BioPhoton and others added 7 commits February 27, 2022 12:03
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
Copy link
Member

@edbzn edbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need this smosh operator to reduce the number of view subscriptions!

Co-authored-by: push-based-bot <95690470+push-based-bot@users.noreply.github.com>
BioPhoton and others added 2 commits March 24, 2022 13:35
Co-authored-by: push-based-bot <95690470+push-based-bot@users.noreply.github.com>
Copy link
Member

@edbzn edbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think @BioPhoton about moving the second parameter to the third named parameter, for instance, it's easier this way:

smosh(
  {
    prop1: cold('h-h-i-i-i-i-i', { h, i }),
    prop2: cold('_-a-a-_-b-_-b', { _, a, b }),
    prop3: cold('f-f-f-f-f-t-t', { f, t }),
  },
  undefined, // having to pass undefined or [] is not intuitive
  { durationSelector: cold('s') }
);
smosh(
  {
    prop1: cold('h-h-i-i-i-i-i', { h, i }),
    prop2: cold('_-a-a-_-b-_-b', { _, a, b }),
    prop3: cold('f-f-f-f-f-t-t', { f, t }),
  },
  { durationSelector: cold('s') }
);
smosh(
  {
    prop1: cold('h-h-i-i-i-i-i', { h, i }),
    prop2: cold('_-a-a-_-b-_-b', { _, a, b }),
    prop3: cold('f-f-f-f-f-t-t', { f, t }),
  },
  { durationSelector: cold('s'), spreads: [prop$] }
);

@BioPhoton
Copy link
Member Author

I like it @edbzn!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core team meeting 📖 Docs API Documentation in the source code { } State @rx-angular/state related 🛂 Test Unit tests, e2e tests, integration tests, test coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants