Conversation
Collaborator
|
I think we need merge #372 first, and then bump MSRV. |
bluss
force-pushed
the
bluss/bump-ndarray
branch
from
353d342 to
91846a0
Compare
|
When i understand correctly, there is just the MSRV bump missing, what @Dirreke already pointed to. At least the one red job of CI is complaining about exactly that: |
|
I tried to add just the missing commit here, to update the rust versions of the CI runners. I did not find a way to add it to the existing pull-request, so i created a new one: #389 |
Merged
Collaborator
|
Before we discuss MSRV, let’s rebase this PR, rerun the CI, and merge it first. Afterward, we can decide MSRV and add an MSRV test to the CI. |
|
This request can be closed, since #389 is already merged and contains the same commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #379. Opened new PR to run tests again, need to see their status and logs.