I'm thinking we maybe want to have the continue on error flag set on the clippy job (so that other tests also run) (?)

I'm thinking we maybe want to have the continue on error flag set on the clippy job (so that other tests also run) (?)

I think they were running. (I was just force-pushing to fix warnings before they got a chance to finish.) I have seen items canceled when other items fail, but from what I've seen, it's always been within a job (i.e. within "tests" or within "cross_test"), so the tests should still run if clippy fails. I'll check to make sure.

I think you'd want continue on error, but yeah I wonder why they are running anyway.

https://github.com/petgraph/petgraph/blob/master/.github/workflows/ci.yml#L45

I came across these pages regarding continue-on-error:

• https://stackoverflow.com/q/62045967
• https://github.community/t/continue-on-error-allow-failure-ui-indication/16773

which seem to indicate that continue-on-error makes the job always "pass", i.e. get a green check. They suggest to use if: succeeded() || failed() in the run step if you want a job to continue running after a step fails or if: always() if you want it to also continue running after a step is canceled.

I'll try adding continue-on-error to the (currently failing) clippy job to see what happens. Edit: It appears that the links above are outdated. CI (correctly) gives a red X for the clippy job when clippy fails even with continue-on-error: true. That said, since the other jobs continue running after clippy fails even without continue-on-error: true, there doesn't seem to be much reason to add continue-on-error: true.

Edit: Yes, the canceling of items appears to occur within jobs, but not across jobs. (The jobs are tests, cross_test, and clippy.) In the most recent CI test, the clippy job failed, the items in the cross_test job passed, and the beta item in the tests job failed, which caused the other items in the tests job to be canceled.

Thanks