Implement Sync for ArrayParts#1552
Conversation
|
Switching the Sync impl from ArrayParts to ArrayRef should allow this to pass the tests. |
|
@akern40 I'm really surprised that this bug didn't appear during your refactor. We have plenty of parallel code and tests in this repo. |
|
I’m not that surprised that it didn’t show up because while it doesn’t prevent this it does prevent doing this (which is much less common) My rational is that since both of those examples work with ArrayView (I guess because ArrayView inherit the Sync impl from ArrayBase) this should also work with ArrayRef. |
|
Also I saw that Send is implemented on ArrayBase, if this PR is accepted maybe Send should also be implemented on ArrayRef. |
|
Ya I was surprised as well. I think this is good to go, but can you add |
|
@gaumut thank you very much for your contribution, and @nilgoyette thank you as always for staying on top of PRs! |
Closes #1548