add axis_windows_with_stride() method#1460
Merged
akern40 merged 4 commits intorust-ndarray:masterfrom May 21, 2025
Merged
Conversation
akern40
reviewed
Dec 13, 2024
Collaborator
akern40
left a comment
akern40
left a comment
There was a problem hiding this comment.
Thanks for the PR! This is looking good, and great testing. Just the one question about keeping the name new. If you could run rustfmt (which must be run on +nightly) that would also be good.
goertzenator
force-pushed
the
axis_windows_with_stride
branch
from
03fdd5f to
c0961a6
Compare
Contributor
Author
|
|
Collaborator
|
Let me fix our CI/CD and then this should be good to merge |
Collaborator
|
@goertzenator sorry I dropped the ball on this! Would you mind please running |
akern40
force-pushed
the
axis_windows_with_stride
branch
from
c0961a6 to
a1dc7cd
Compare
akern40
force-pushed
the
axis_windows_with_stride
branch
from
183e1a0 to
5373073
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a variation of
axis_windows()that accepts a stride parameter. It is analogous to thewindows_with_stride()variant ofwindows(). This was already 95% implemented thanks to the work of @jonasBoss in commit 2aec819.Ref issue #1304.