Merged
Conversation
adamreichold
reviewed
Apr 6, 2024
| @@ -193,6 +193,3 @@ macro_rules! impl_approx_traits { | |||
|
|
|||
| #[cfg(feature = "approx")] | |||
| impl_approx_traits!(approx, "**Requires crate feature `\"approx\"`.**"); | |||
Collaborator
There was a problem hiding this comment.
I guess you want to keep the macro around for the time when approx 0.6 is relevant?
From a code maintenance perspective, getting the code out of the macro would be preferable IMHO.
Member
Author
There was a problem hiding this comment.
I'm just adapting necessary changes with as low overhead as possible, unfortunately. I'm going for less than perfect for this release 🙂
Keeping the macro doesn't sound so useful no, approx doesn't look like it's going to have a release soon. If you want to fix this, it would be welcome too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old approx-0_5 feature is removed, the approx feature points to approx 0.5
Uses and supersedes #1063. Closes #1063