Add additional array -> array view conversions#1130
Merged
Conversation
bluss
force-pushed
the
array-view-from
branch
from
bee5664 to
01fd6fc
Compare
jturner314
reviewed
Dec 7, 2021
Member
jturner314
left a comment
jturner314
left a comment
There was a problem hiding this comment.
This PR looks good to me, except for one comment about the docs.
| /// Implementation of ArrayView2::from(&[[A; N]; M]) | ||
| /// | ||
| /// **Panics** if the product of non-zero axis lengths overflows `isize` (This can only occur if A | ||
| /// is zero-sized because slices cannot contain more than `isize::MAX` number of bytes). |
Member
There was a problem hiding this comment.
This comment and the one for ArrayViewMut should mention that another panicking case is when N == 0 and the number of rows is greater than isize::MAX, even if A is not zero-sized. (See #1131.)
bluss
force-pushed
the
array-view-from
branch
2 times, most recently
from
ea5cf10 to
cf9316a
Compare
It is best to be "complete" with implementations when possible, since it can always be a breaking change to add it later. As shown in the test change in this commit, this is a minor type inference breakage due to `ArrayView::from(&[])` being ambiguous. Empty array views should be relatively rare - and one can use `ArrayView1` or other means to disambiguate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is best to be "complete" with implementations when possible, since
it can always be a breaking change to add it later.
As shown in the test change in this commit, this is a minor type
inference breakage due to
ArrayView::from(&[])being ambiguous.Empty array views should be relatively rare - and one can use
ArrayView1or other means to disambiguate.