Skip to content

Tests and CI/CD for no_std support with approx #1447

Closed

Description

@akern40

Just days after ndarray introduced no_std, approx did the same. As a result, users can use both no_std and approx together via --no-default-features --features approx. Currently, our CI/CD runs one test batch for --no-default-features and one test batch for --features docs, which includes approx; as a result, it misses a number of tests which are configured with feature = approx but not configured with feature = std. Examples include:

  • var_axis, std_axis, etc in numeric.rs
  • The bottommost test of serial_many_dim_serde in serialization-tests, which uses linspace (requires std) but isn't marked with feature = serde

These should be pretty simple fixes: add the appropriate cfgs and alter the CI/CD to include a test run that has --no-default-features with approx.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions