Revert canonicalizing the build directory and make the path absolute instead #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ChrisDenton
added a commit
that referenced
this pull request
Dec 17, 2025
## 🤖 New release * `cmake`: 0.1.56 -> 0.1.57 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.1.57](v0.1.56...v0.1.57) - 2025-12-17 ### Fixed - Revert canonicalizing the build directory and make the path absolute instead ([#267](#267)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Chris Denton <chris@chrisdenton.dev>
ghedo
added a commit
to cloudflare/quiche
that referenced
this pull request
Dec 19, 2025
The issue we had on Windows seems to have been fixed in version 0.1.57 rust-lang/cmake-rs#267 This reverts commit 225b656.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than canonicalising the build directory this simply makes it absolute. Unfortunately the current MSRV doesn't allow us to use
std::path::absoluteso for Windows I've added a direct call to the Windows API.Since the motivation for #200 is Windows, on non-Windows platforms this is now a no-op.
Fixes cloudflare/boring#414
cc @ghedo