Cmake should probably support \\?\, right? Seems like this may be worth an issue on their end. Cc @vron if you may want to open one.

Cmake should probably support \\?\, right?

I would hope so, yes! Though it's possible it's some dependency that's ultimately to blame.

This breaks long paths and file path components that have different meaning under the DOS path parser.

You can't remove the verbatim prefix without checking whether the rest of the path is actually compatible. \\?\C:\ may not be usable as C:\ paths.

See what path validation is done in the dunce crate, or just use that crate.

I am aware. The only cases that could practical fail here are:

• A directory component ends in a single dot
• The path ends in a dot or a space
• The basename is equivalent to a device name (drive paths only)

However, these cases have always broken because we use the build_dir path to set the current directory, which doesn't support such paths. The absolute best we could do here is error with good diagnostics. But that's only helpful if the path made it this far without breaking something.

FTR, this seems to have broken Windows builds for the boring crate cloudflare/boring#414

I'll investigate but are you sure it wasn't #250?

My first suspicion would be that this was caused by the canonicalisation itself.

@ChrisDenton not really, no, I didn't have time to investigate so I was just going from what was reported... and, yes, I think you are right, I bumped cmake to 0.1.57 at cloudflare/quiche#2296 and the Windows builds seem to be working now. Thank you!