Skip to content

Conversation

@runningcode
Copy link
Owner

@runningcode runningcode commented Feb 22, 2024

Looking for feedback on:

  • Is there a way to avoid redeclaring the Gradle Enterprise plugin version so many times?
  • Is there a simpler way to share the build cache configuration to avoid the following message:

The build cache configuration of the root build differs from the build cache configuration of the early evaluated ':playground-plugin', ':supportBuildSrc' included builds. It is recommended to keep them consistent, see here

See this scan for the warning.

ShikaSD and others added 30 commits February 28, 2024 21:47
Fixes: 322205135
Change-Id: I94635cea9a8353f1fb40806c3f7b0944af85cefb
Paging playground build is failing due to b/325886853. The proper fix is complex. We disable config-cache for paging-playground in the meantime.

Test: n/a
Bug: 327484645
Change-Id: I78c3e46c1ac0fc034aa1746fa4eaa87d7e4780f2
inputConfigData

Test: ./gradlew\
 📷camera-camera2-pipe:testDebugUnitTest\
 📷camera-camera2-pipe-testing:testDebugUnitTest\
 📷camera-camera2-pipe-integration:testDebugUnitTest
Change-Id: I66e96fac2a1f345e5b2c71bc62cce3540b6e2429
- Add contentDescriptions to buttons
- Group radio buttons with their labels

Test: manually
Change-Id: I26c0f9d06e69f0c7a44a899d724ebe5230c0e70e
Test: ./gradlew checkApi

RelNote: "Removed ExperimentalAPI tag from MapWithContentTemplate"

Change-Id: I66db8377b81c4bc8629f725b0973ef2b042a0938
Also apply the rule to `CameraUseCaseAdapterTest`. The caveats is that it more than tripples the run time. So we only want to apply the rule where it's necessary.

Bug: 326800518
Test: manual test and ./gradlew bOS
Change-Id: I0d1bff7ad5261be31bc5ce2e24bf970f18f9a7b4
This reverts commit 2d14e5c.

Reason for revert: It slows down configuration phase by 16s, needs investigation

Change-Id: I9ed3c88f038810b17f5dfeaca2e07ba220ce98b5
Change-Id: I1a6a33b987bb0b0eb606d0fa657dffd4ce7c9571
This reverts commit a7138c5.

Reason for revert: b/327503741

Change-Id: If38f7a80b7f78d122750e7f356e8a74dc348fffb
… only one inputConfigData" into androidx-main
Before this change, DataStore didn't handle the CorruptionException for both the reads and writes after initialization.

Fixes: 289582516
Test: ./gradlew :datastore:datastore-core:jvmTest
Change-Id: Icb07b140017b62a905d3626f82aeb993f636c053
Test: Updated unit tests. Updated benchmarks because Popup can't be benchmarked directly
Fixes: b/202810604, b/205589613, b/266109857, b/311257475, b/318007669
Change-Id: Id7a53238cdbcde8c6ecaebea1f6c943a852b40f4
Most notably, EDM focusability is now customizable.
Also cleaned up some doc wording.

Test: Updated unit tests
Bug: b/323694447
Fixes: b/278609042
Relnote: "ExposedDropdownMenu is now implemented using Popup. The
  behavior should be the same except focusable menus with editible
  text fields may be dismissed when typing on the keyboard."
Relnote: "Added parameters to customize ExposedDropdownMenu.
  In particular, menus now have a `focusable` parameter
  (default `true`) that should be set to `false` when working
  with editable text fields."
Change-Id: I4184c21ee9f6ac3a5dcffceb1014b3e4b26eccb9
Test: N/A
Relnote: N/A
Change-Id: Ia13abba7f5ad6ddf82850691eb465c40258a0162
Relnote: "PathParser is now final. interpolatePathDataNodes now throws an exception for incompatible arguments instead of return a boolean. nodesToPath now belongs to PathParser rather than PathParser.PathDataNode."
Test: ./gradlew :transition:transition:lintDebug
Bug: 305941698
Change-Id: I20d624307bd376de9ba89d1c8b623cb56bcca580
This way we unify code in
ListenableWorkerImplClient.execute / RemoteWorkManagerClient.execute.

It is done in preparation of removing usage of SettableFuture

Test: refactoring
Change-Id: I5bf670bff3695b1f1ee6602903139ede72726db1
drchen and others added 27 commits March 5, 2024 18:07
Also rename most methods and properties that mention `chars` in their name, the suffix is now redundant.

Codepoint APIs can always be added later on. Also the existing methods that provide chars based implementation can be used convert to codepoint space.

Relnote: "Removed Codepoints related methods and properties under `TextFieldState` and `TextFieldBuffer`. Also removed the `inChars` suffixes from the remaining selection and composition related APIs."
Test: ./gradlew :compose:foundation:foundation:cAT
Change-Id: Ief7ce54a84a9276d79b1e5bed50801b7d9b9b524
Test: ./gradlew -Pandroidx.validateNoUnrecognizedMessages --rerun-tasks :benchmark:benchmark-macro:generateDebugProtos :benchmark:benchmark-macro:compileDebugKotlin

Fixes deprecation warnings showing up in generated hashCode/copy methods.

Change-Id: Icc15eed90f822f050cae8c8b0fbb00d4f8805b14
Also moves proto src to prebuilts dir to ensure they stay in sync

Test: ./gradlew bench:b-c:cC bench:b-m:cC

Change-Id: I3753f6edb71d348e7e24946b215c7297ba32d58e
* changes:
  Fix IllegalArgumentException in SpeedListener
  Add API for accessing vehicle exterior dimensions.
* changes:
  Update perfetto to 249090360a31856f2a5022f52abfb8dc54f69a0b
  Update wire to 4.9.7
Bring the number of aarch64 instructions in calculateImpulseVelocity
from 165 down to 120 by doing two things:
- Avoid a couple of array accesses per loop
- Remove the branches for sampleCount <= 2. By construction, the
  method is never invoked when sampleCount < 2, and sampleCount == 2
  is not the common path (with manual fling and by being
  *extremely* careful with an absurdly short fling I can generate a
  sampleCount of 3)

Test: VelocityTrackerTest
Relnote: N/A
Change-Id: I0465e0d8a0d60d10b5e633188d1499d8b0da4b44
TruthFailureSubject is the last class to migrate, which finally enables
migrating a large suite of ExpectFailure tests.

In order to get these tests passing, it was necessary to make a bunch of fixes
for string representation of chained subjects, especially allowing string
overrides and specific behaviors around printing names of classes.

Relnote: "N/A"
Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew kruth:kruth:allTests -Pandroidx.enabled.kmp.target.platforms=+LINUX
Change-Id: I500ebb61bef4b8e4781d638d3fa505cf5170e59e
For arguments of NavType<String>, arg values that are in the form of curly braces around argument name is now allowed as valid values. For all other types, this value is still considered as invalid (or absent of argument value).

Internal tests have been updated to reflect this new change. To be precise:

1. NavControllerRouteTest.kt - tests that are setup with absence of value were passing values of {argName} with StringType. Since this is no longer processed as absence of value, StringType has been changed to IntArrayType.

2. NavDeepLinkTest - likewise as NavControllerRouteTest.kt, with additional new test to assert that {argName} is invalid for non-String types.

Test: ./gradlew navigation:navigation-common:cC
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 327274038
Relnote: "Query parameters in DeepLink now allows values in the form of curly braces around argument name (i.e. {argName}) as valid values for string-based NavTypes. This contrasts with before where such a value would be considered invalid (or absence of value) for all types."
Change-Id: I183028e2f77d63158a9a567c43da016722397cb8
Fixes: 328308833
Test: InstrumentationResultsTest
Relnote: "Fixes method tracing warning to be on separate line from
microbench output"

Change-Id: I0455c4edcdc592c56e60dd19bd32d9bd33f6af6a
  The test is making subsequent camera pretests fail and have CAMERA_UNAVAILABLE error for camera-pipe config only, probably related to extensions support on camera-pipe.

Bug: 328022142
Bug: 275493663
Test: N/A
Change-Id: Id82d64e4f3f05cd53966b2389bf03ce3b92b2291
…onType to CurrentExtensionMode" into androidx-main
…tations in camera-pipe-integration" into androidx-main
@runningcode runningcode force-pushed the no/use-remote-build-cache branch from 593d65f to a2c71e9 Compare March 6, 2024 11:13
This migrates the access to the Develocity Build Cache to use Access Key based authentication instead
of username and password authentication. This means that the access will use the same access key as is
is used for Build Scan publication.

Here is more information on the Develocity Connector [see here](https://docs.gradle.com/enterprise/gradle-plugin/#using_the_develocity_connector)
@runningcode runningcode force-pushed the no/use-remote-build-cache branch from a2c71e9 to 8dfe7f2 Compare March 6, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.