cleanup(blueprints): remove references to named_build_contexts #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-rl
approved these changes
Dec 8, 2025
Contributor
james-rl
left a comment
james-rl
left a comment
There was a problem hiding this comment.
Looks good to me.
One small nit about this PR: the title doesn't reflect the main change. My only concern here is that the changes to the typing are arguably the "fix" part of this change and the change to remove named build context is not a fix at all.
There's another tag I think is more appropriate: improve or cleanup
Other categories here:
https://pulsar.apache.org/contribute/develop-semantic-title/
sid-rl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we want to hide named_build_contexts until needed. also, added type fixes to agent source creation and unit tests.