Restore the scripts/test file #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alb-rl
reviewed
Nov 18, 2025
| echo "RUNLOOP_BASE_URL=https://api.runloop.pro" >> $GITHUB_ENV | ||
| fi | ||
| echo "DEBUG=false" >> $GITHUB_ENV | ||
| echo "RUN_SMOKETESTS=1" >> $GITHUB_ENV |
Contributor
There was a problem hiding this comment.
was this env var unnecessary?
Contributor
Author
There was a problem hiding this comment.
Yeah, it was for the scripts/test script, and this never invokes that.
Changes were made here to avoid running smoketests by default, but these were unneccessary and were causing a merge conflict. Smoketests are disabled by default in pyproject.toml, and the github action that runs smoke tests already enables them and runs them directly.
adam-rl
force-pushed
the
adam/fix-smoketest-conflict
branch
from
0afdd5f to
d651659
Compare
alb-rl
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes were made here to avoid running smoketests by default, but these were unneccessary and were causing a merge conflict.
Smoketests are disabled by default in pyproject.toml, and the github action that runs smoke tests already enables them and runs them directly.