added file system mount parameter to devboxes.create_and_await_running, and cleaned up NOT_GIVEN default params to match generated code signatures #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g, and cleaned up NOT_GIVEN default params to match generated code signatures
sid-rl
commented
Nov 12, 2025
| file_mounts: Optional[Dict[str, str]] | Omit = omit, | ||
| launch_parameters: Optional[LaunchParameters] | Omit = omit, | ||
| metadata: Optional[Dict[str, str]] | Omit = omit, | ||
| mounts: Optional[Iterable[Mount]] | Omit = omit, |
Contributor
Author
There was a problem hiding this comment.
this is the only extra parameter
sid-rl
commented
Nov 12, 2025
| file_mounts: Optional[Dict[str, str]] | Omit = omit, | ||
| launch_parameters: Optional[LaunchParameters] | Omit = omit, | ||
| metadata: Optional[Dict[str, str]] | Omit = omit, | ||
| mounts: Optional[Iterable[Mount]] | Omit = omit, |
Contributor
Author
There was a problem hiding this comment.
this is the only extra parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devboxes.create() has a mounts parameter that is missing from devboxes.create_and_await_running(). this adds in that parameter, which is passed through to create().
also, this cleans up the default parameters so that we appropriately use omit/not_given as default parameters in our manual wrappers instead of NOT_GIVEN to match generated function signatures.