-
Notifications
You must be signed in to change notification settings - Fork 1
file_mount validation limits for python client #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
48a3c0f
added file_mount validation limits
james-rl 61c00ca
improved error message handling to use notification pattern instead o…
james-rl cccf210
fixed broken import
james-rl 5266abb
made file_mount limits more restrictive
james-rl 640c4e9
updated with actual tested limits
james-rl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| from __future__ import annotations | ||
|
|
||
| from typing import List, Optional | ||
|
|
||
|
|
||
| class ValidationNotification: | ||
| """Collects validation errors without raising exceptions. | ||
|
|
||
| This follows the notification pattern: validations append errors, and callers | ||
| decide how to react (e.g., surface all messages at once or abort). | ||
| """ | ||
|
|
||
| def __init__(self) -> None: | ||
| self._errors: List[str] = [] | ||
| self._causes: List[Optional[Exception]] = [] | ||
|
|
||
| def add_error(self, message: str, cause: Optional[Exception] = None) -> None: | ||
| self._errors.append(message) | ||
| self._causes.append(cause) | ||
|
|
||
| def has_errors(self) -> bool: | ||
| return len(self._errors) > 0 | ||
|
|
||
| @property | ||
| def errors(self) -> List[str]: | ||
| # Return a copy to avoid external mutation | ||
| return list(self._errors) | ||
|
|
||
| def error_message(self) -> str: | ||
| # Join with semicolons to present multiple issues succinctly | ||
| return "; ".join(self._errors) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a good idea to test that we don't reject file mounts when under or precisely at the limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are just client-side validations. There's no point being hyper-precise about these limits since they're really enforced on the server side anyway -- there's nothing to stop a caller ignoring our client & using our API endpoints directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!