Skip to content

fix: klaviyo bulk upload and BingAds OC #5305

Merged
yashasvibajpai merged 2 commits into
release/1.38.xfrom
fix.integration_klaviyo_bingadsoc
Nov 19, 2024
Merged

fix: klaviyo bulk upload and BingAds OC #5305
yashasvibajpai merged 2 commits into
release/1.38.xfrom
fix.integration_klaviyo_bingadsoc

Conversation

@yashasvibajpai

@yashasvibajpai yashasvibajpai commented Nov 19, 2024

Copy link
Copy Markdown
Contributor

Description

add fixes for

  • Klaviyo Bulk Upload
  • BingAds Offiine conversions integrations

Linear Ticket

Resolves INT-2820 INT-2916

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

ItsSudip and others added 2 commits November 19, 2024 13:08
@ItsSudip
fix: bing ads audience (#5299)
6d0a266
@yashasvibajpai
chore: handle 500kb limit, refactor to service impl (#5302)
08f4af1 
* chore: handle 500kb limit, refactor to service impl

* chore: fix mock

* chore: fix mock newline

* chore: fix apiservice newline

* chore: move error
@codecov

codecov Bot commented Nov 19, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 36.55172% with 92 lines in your changes missing coverage. Please review.

Project coverage is 73.47%. Comparing base (94aa254) to head (08f4af1).
Report is 1 commits behind head on release/1.38.x.

Files with missing lines Patch % Lines
...destinationmanager/klaviyobulkupload/apiService.go 12.76% 82 Missing ⚠️
...tionmanager/klaviyobulkupload/klaviyobulkupload.go 80.00% 8 Missing and 2 partials ⚠️
Additional details and impacted files 
@@                Coverage Diff                 @@
##           release/1.38.x    #5305      +/-   ##
==================================================
+ Coverage           73.40%   73.47%   +0.07%     
==================================================
  Files                 424      425       +1     
  Lines               60243    59965     -278     
==================================================
- Hits                44221    44060     -161     
+ Misses              13578    13434     -144     
- Partials             2444     2471      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@yashasvibajpai yashasvibajpai merged commit 9c9ef73 into release/1.38.x Nov 19, 2024
@yashasvibajpai yashasvibajpai deleted the fix.integration_klaviyo_bingadsoc branch November 19, 2024 09:16
This was referenced Nov 19, 2024
Merged
Merged
Merged
@devops-github-rudderstack devops-github-rudderstack mentioned this pull request Dec 4, 2024
Merged
koladilip added a commit that referenced this pull request Dec 9, 2024
@koladilip @achettyiitr
@devops-github-rudderstack @yashasvibajpai @ItsSudip
fix: json marshal l errors when parsing poll response from klaviyo (#…
446666b 
…5316)

* fix: bq partitioning for additional columns (#5293)

* chore: release 1.38.1 (#5295)

* fix: klaviyo bulk upload and BingAds OC  (#5305)

* fix: bing ads audience (#5299)

* chore: handle 500kb limit, refactor to service impl (#5302)

* chore: handle 500kb limit, refactor to service impl

* chore: fix mock

* chore: fix mock newline

* chore: fix apiservice newline

* chore: move error

---------

Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>

* chore: release 1.38.2 (#5306)

* fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk (#5309)

* chore: release 1.38.3 (#5311)

* fix: json marshal l errors when parsing poll response from klaviyo

* fix: payload size limit issue

* chore: add rate limiter in http client for Klaviyo Bulk Upload async destination (#5353)

* fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk

* chore: add rate limited http client for klaviyo bulk

* refactor: add rate limiter klaviyo bulk upload

---------

Co-authored-by: Dilip Kola <kdilipkola@gmail.com>

---------

Co-authored-by: Akash Chetty <achetty.iitr@gmail.com>
Co-authored-by: devops-github-rudderstack <88187154+devops-github-rudderstack@users.noreply.github.com>
Co-authored-by: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com>
Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
This was referenced Dec 9, 2024
Merged
Merged
Merged
Merged
mihir20 added a commit that referenced this pull request Dec 20, 2024
@devops-github-rudderstack @achettyiitr
@yashasvibajpai @ItsSudip @Sidddddarth @mihir20
chore: sync release v1.38.4 to main branch (#5333)
98827e5 
* fix: bq partitioning for additional columns (#5293)

* chore: release 1.38.1 (#5295)

* fix: klaviyo bulk upload and BingAds OC  (#5305)

* fix: bing ads audience (#5299)

* chore: handle 500kb limit, refactor to service impl (#5302)

* chore: handle 500kb limit, refactor to service impl

* chore: fix mock

* chore: fix mock newline

* chore: fix apiservice newline

* chore: move error

---------

Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>

* chore: release 1.38.2 (#5306)

* fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk (#5309)

* chore: release 1.38.3 (#5311)

* fix: disable vacuum at startup for reporting (#5325)

* chore: remove full vacuum at flusher startup (#5332)

* chore: release 1.38.4 (#5331)

* update action to apidom-validate

---------

Co-authored-by: Akash Chetty <achetty.iitr@gmail.com>
Co-authored-by: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com>
Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
Co-authored-by: siddarth.msv <82795818+Sidddddarth@users.noreply.github.com>
Co-authored-by: mihir <mihir20121997@gmail.com>
mihir20 added a commit that referenced this pull request Dec 23, 2024
@devops-github-rudderstack @achettyiitr
@yashasvibajpai @ItsSudip @Sidddddarth @mihir20
chore: sync release v1.38.4 to main branch (#5333)
dd39ddc 
* fix: bq partitioning for additional columns (#5293)

* chore: release 1.38.1 (#5295)

* fix: klaviyo bulk upload and BingAds OC  (#5305)

* fix: bing ads audience (#5299)

* chore: handle 500kb limit, refactor to service impl (#5302)

* chore: handle 500kb limit, refactor to service impl

* chore: fix mock

* chore: fix mock newline

* chore: fix apiservice newline

* chore: move error

---------

Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>

* chore: release 1.38.2 (#5306)

* fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk (#5309)

* chore: release 1.38.3 (#5311)

* fix: disable vacuum at startup for reporting (#5325)

* chore: remove full vacuum at flusher startup (#5332)

* chore: release 1.38.4 (#5331)

* update action to apidom-validate

---------

Co-authored-by: Akash Chetty <achetty.iitr@gmail.com>
Co-authored-by: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com>
Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
Co-authored-by: siddarth.msv <82795818+Sidddddarth@users.noreply.github.com>
Co-authored-by: mihir <mihir20121997@gmail.com>
(cherry picked from commit 98827e5)
mihir20 added a commit that referenced this pull request Dec 23, 2024
@mihir20 @devops-github-rudderstack
chore: sync release v1.38.4 to main branch (#5333) (#5387)
3605e90 
* fix: bq partitioning for additional columns (#5293)

* chore: release 1.38.1 (#5295)

* fix: klaviyo bulk upload and BingAds OC  (#5305)

* fix: bing ads audience (#5299)

* chore: handle 500kb limit, refactor to service impl (#5302)

* chore: handle 500kb limit, refactor to service impl

* chore: fix mock

* chore: fix mock newline

* chore: fix apiservice newline

* chore: move error

---------

Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>

* chore: release 1.38.2 (#5306)

* fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk (#5309)

* chore: release 1.38.3 (#5311)

* fix: disable vacuum at startup for reporting (#5325)

* chore: remove full vacuum at flusher startup (#5332)

* chore: release 1.38.4 (#5331)

* update action to apidom-validate

---------

Co-authored-by: Akash Chetty <achetty.iitr@gmail.com>
Co-authored-by: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com>
Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
Co-authored-by: siddarth.msv <82795818+Sidddddarth@users.noreply.github.com>
Co-authored-by: mihir <mihir20121997@gmail.com>
(cherry picked from commit 98827e5)

Co-authored-by: devops-github-rudderstack <88187154+devops-github-rudderstack@users.noreply.github.com>
This was referenced Jan 6, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ItsSudip ItsSudip ItsSudip approved these changes

+1 more reviewer

@koladilip koladilip koladilip approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yashasvibajpai @koladilip @ItsSudip