fix: parse error due incrorrect csv response from marketo-n#5252
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/1.37.x #5252 +/- ##
==================================================
+ Coverage 73.23% 73.29% +0.06%
==================================================
Files 424 424
Lines 59960 59967 +7
==================================================
+ Hits 43909 43955 +46
+ Misses 13590 13553 -37
+ Partials 2461 2459 -2 ☔ View full report in Codecov by Sentry. |
koladilip
reviewed
Nov 1, 2024
koladilip
approved these changes
Nov 1, 2024
krishna2020
reviewed
Nov 1, 2024
| break | ||
| } | ||
| if err != nil { | ||
| m.logger.Error("Error in parsing csv response", err.Error()) |
Contributor
There was a problem hiding this comment.
Is line number captured in err.Error() ?
krishna2020
approved these changes
Nov 1, 2024
This was referenced Nov 1, 2024
Merged
This was referenced Nov 11, 2024
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The issue is due to incorrect csv response from marketo, hence rather than reading all rows at once we are reading each row separately.
For the erroneous rows we cannot identify which particular job as we cant generate hash to get corresponding job id hence these specific ones will be marked as success (we need to figure out a long term solution for this though)
Security