Skip to content

fix: add error logs for handle async for visibility of error#5248

Merged
utsabc merged 2 commits into
release/1.37.xfrom
fix.marketo-bulk-upload-logs
Oct 30, 2024
Merged

fix: add error logs for handle async for visibility of error#5248
utsabc merged 2 commits into
release/1.37.xfrom
fix.marketo-bulk-upload-logs

Conversation

@utsabc

@utsabc utsabc commented Oct 30, 2024

Copy link
Copy Markdown
Contributor

Description

Add logs for visibility for errors

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@utsabc utsabc changed the base branch from master to release/1.37.x October 30, 2024 08:36
@utsabc utsabc merged commit 03d2472 into release/1.37.x Oct 30, 2024
@utsabc utsabc deleted the fix.marketo-bulk-upload-logs branch October 30, 2024 10:19
@codecov

codecov Bot commented Oct 30, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.21%. Comparing base (c18d8be) to head (cdc1548).
Report is 1 commits behind head on release/1.37.x.

Files with missing lines Patch % Lines
router/batchrouter/handle_async.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/1.37.x    #5248      +/-   ##
==================================================
- Coverage           73.25%   73.21%   -0.04%     
==================================================
  Files                 424      424              
  Lines               59960    59960              
==================================================
- Hits                43921    43899      -22     
- Misses              13581    13598      +17     
- Partials             2458     2463       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants