Skip to content

chore: remove bugsnag#5014

Merged
lvrach merged 9 commits into
masterfrom
chore.rm-bugsnag
Aug 29, 2024
Merged

chore: remove bugsnag#5014
lvrach merged 9 commits into
masterfrom
chore.rm-bugsnag

Conversation

@lvrach

@lvrach lvrach commented Aug 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Remove bugsnag from rudder-server, capturing panics using logs instead.

Linear Ticket

https://linear.app/rudderstack/issue/PIPE-1435/remove-bug-snag

Resolves PIPE-1435
Resolves PIPE-611

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@coderabbitai

coderabbitai Bot commented Aug 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

fracasula
fracasula reviewed Aug 20, 2024
View reviewed changes
Comment thread utils/crash/noop.go Outdated
fracasula
fracasula reviewed Aug 20, 2024
View reviewed changes
Comment thread utils/crash/logger.go Outdated
achettyiitr
achettyiitr reviewed Aug 20, 2024
View reviewed changes
Comment thread utils/crash/logger.go Outdated
@lvrach lvrach marked this pull request as ready for review August 22, 2024 12:10
achettyiitr
achettyiitr reviewed Aug 27, 2024
View reviewed changes
Comment thread utils/crash/logger.go Outdated
@codecov

codecov Bot commented Aug 27, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 94.05941% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.79%. Comparing base (c18669b) to head (f7ca33a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
app/apphandlers/processorAppHandler.go 0.00% 4 Missing ⚠️
router/batchrouter/handle_lifecycle.go 60.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5014      +/-   ##
==========================================
+ Coverage   74.65%   74.79%   +0.13%     
==========================================
  Files         430      433       +3     
  Lines       50144    50149       +5     
==========================================
+ Hits        37436    37508      +72     
+ Misses      10230    10169      -61     
+ Partials     2478     2472       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fracasula
fracasula approved these changes Aug 28, 2024
View reviewed changes

@fracasula fracasula left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor comments 👍

Comment thread utils/crash/default.go Outdated
Comment thread rruntime/goroutine-factory.go
go func() {
ctx := bugsnag.StartSession(context.Background())
defer misc.BugsnagNotify(ctx, "Warehouse")()
defer crash.Notify("Warehouse")()

@fracasula fracasula Aug 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use the wrapper here? Same for Core.

@lvrach lvrach Aug 29, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wrapper requires a diffrent signature for function, func() error.

@lvrach lvrach enabled auto-merge (squash) August 29, 2024 13:35
@lvrach lvrach merged commit d68ceb3 into master Aug 29, 2024
@lvrach lvrach deleted the chore.rm-bugsnag branch August 29, 2024 13:52
This was referenced Sep 2, 2024
Merged
Merged
This was referenced Sep 16, 2024
Closed
Closed
Closed
Closed
This was referenced Sep 16, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fracasula fracasula fracasula approved these changes

@achettyiitr achettyiitr achettyiitr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lvrach @fracasula @achettyiitr