fix: use Git::Deprecation.warn for deprecated methods (fixes #842) #846
+203
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouball
force-pushed
the
fix/842-deprecation-warn
branch
2 times, most recently
from
6bfd78e to
160f786
Compare
Replace invalid Git.deprecation/Git.deprecated calls with Git::Deprecation.warn. Consolidate all deprecation-related tests into tests/units/test_deprecations.rb. Changes: - Base: use Git::Deprecation.warn in is_* methods and set_index/set_working - Object::Commit#set_commit warns properly - Consolidated log/base/object deprecation tests into one file - Removed redundant test files All tests pass locally: 430 tests, 1582 assertions.
jcouball
force-pushed
the
fix/842-deprecation-warn
branch
from
160f786 to
22055b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #842 by replacing incorrect calls to nonexistent methods (Git.deprecation/Git.deprecated) with the correct Git::Deprecation.warn API.
Root Cause
Issue #842 reported that deprecated methods were calling Git.deprecation which doesn't exist, causing NoMethodError instead of deprecation warnings.
Changes Made
Fixed Deprecation Warnings
Test Improvements
Closes #842