Internal refactor of Git::Lib command #618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
In order to support moving to using a spawn like interface for calling git commands in a subprocess (rather than backticks), make the following changes to Git::Lib#command:
cmdparameter and theoptsparameter into a single Array parameter namedcmdcmdparameter to have nested arrays. Enforce that it is an Array of Strings only by raising anArgumentErrorwhencmdis anything other than an Array of Strings.#commandworks (and are not passed on to the git command likeredirectandchomp) should be passed as keyword parameters to#commandinstead of a Hash at the end of thecmd/optsArray parameter.These changes impact both the implementation of
Git::Lib#commandas well as its callers.