feat: add --gpg-sign option on commits #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: othmane399 <othmane.elmassari@doctolib.com>
othmane399
force-pushed
the
master
branch
2 times, most recently
from
6816f04 to
7690399
Compare
Contributor
Author
|
@jcouball can you review this PR please ? it's about to add --gpg-sign flag on commit method |
othmane399
changed the title
jcouball
reviewed
Mar 27, 2021
Member
jcouball
left a comment
jcouball
left a comment
There was a problem hiding this comment.
Thank you for submitting this PR. I have a couple of requests:
- I suggest that the key passed to
Git::Lib#commitbe 'gpg_sign' instead of just 'sign'. I think it is important to keep this close to the git CLI. I know this hasn't been done consistently, but I think it is a good idea. - I suggest, since we are here, allow passing an optional as documented in git-commit. If the value of the key is
truedon't append the"=#{keyid}"to the argument.
Optional (if you don't do this, I can follow up with a separate PR for it):
- Add a test so that calling commit builds the command correctly. I'd stub out
commandfor this test. - Add documentation to the README.md for this option.
Signed-off-by: othmane399 <othmane.elmassari@doctolib.com>
Contributor
Author
|
@jcouball thx for your review. I've done what you have recommended, can you recheck ? |
jcouball
approved these changes
Jun 19, 2021
Member
jcouball
left a comment
jcouball
left a comment
There was a problem hiding this comment.
Thank you for making the requested changes. I follow up with a PR to:
- Add a test so that calling commit builds the command correctly. I'd stub out command for this test.
- Add documentation to the README.md for this option.
I plan on building a new minor release within the next week to get this code into the gem.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
This pull request add and option on
optshash to sign your commits using the default key that has been set in the config file