fix: use Git::Deprecation.warn for deprecated methods (fixes #842)

jcouball · jcouball · commit fb8d51667036 · 2025-11-11T10:40:32.000-08:00
diff --git a/lib/git/base.rb b/lib/git/base.rb
@@ -286,7 +286,10 @@ def local_branch?(branch)
     end
 
     def is_local_branch?(branch) # rubocop:disable Naming/PredicatePrefix
-      Git.deprecation('Git::Base#is_local_branch? is deprecated. Use Git::Base#local_branch? instead.')
+      Git::Deprecation.warn(
+        'Git::Base#is_local_branch? is deprecated and will be removed in a future version. ' \
+        'Use Git::Base#local_branch? instead.'
+      )
       local_branch?(branch)
     end
 
@@ -297,7 +300,10 @@ def remote_branch?(branch)
     end
 
     def is_remote_branch?(branch) # rubocop:disable Naming/PredicatePrefix
-      Git.deprecated('Git::Base#is_remote_branch? is deprecated. Use Git::Base#remote_branch? instead.')
+      Git::Deprecation.warn(
+        'Git::Base#is_remote_branch? is deprecated and will be removed in a future version. ' \
+        'Use Git::Base#remote_branch? instead.'
+      )
       remote_branch?(branch)
     end
 
@@ -308,7 +314,10 @@ def branch?(branch)
     end
 
     def is_branch?(branch) # rubocop:disable Naming/PredicatePrefix
-      Git.deprecated('Git::Base#is_branch? is deprecated. Use Git::Base#branch? instead.')
+      Git::Deprecation.warn(
+        'Git::Base#is_branch? is deprecated and will be removed in a future version. ' \
+        'Use Git::Base#branch? instead.'
+      )
       branch?(branch)
     end
 
diff --git a/lib/git/object.rb b/lib/git/object.rb
@@ -213,7 +213,10 @@ def diff_parent
       end
 
       def set_commit(data) # rubocop:disable Naming/AccessorMethodName
-        Git.deprecation('Git::Object::Commit#set_commit is deprecated. Use #from_data instead.')
+        Git::Deprecation.warn(
+          'Git::Object::Commit#set_commit is deprecated and will be removed in a future version. ' \
+          'Use #from_data instead.'
+        )
         from_data(data)
       end
 
