fix: fix Rubocop Lint/MissingSuper offense

jcouball · jcouball · commit e9e91a88fc33 · 2025-07-03T16:10:33.000-07:00
The Branch, Remote, and Worktree classes all inherit from Path
but do not initialize it. Rather than call super, I am removing the
inheritance. While this could be considered a breaking change,
since the base class was never initialized, objects of these
classes can not make use of the Path methods.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -6,14 +6,6 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 3
-# Configuration parameters: AllowedParentClasses.
-Lint/MissingSuper:
-  Exclude:
-    - 'lib/git/branch.rb'
-    - 'lib/git/remote.rb'
-    - 'lib/git/worktree.rb'
-
 # Offense count: 8
 Lint/StructNewOverride:
   Exclude:
diff --git a/lib/git/branch.rb b/lib/git/branch.rb
@@ -3,7 +3,7 @@
 require 'git/path'
 
 module Git
-  class Branch < Path
+  class Branch
     attr_accessor :full, :remote, :name
 
     def initialize(base, name)
diff --git a/lib/git/remote.rb b/lib/git/remote.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Git
-  class Remote < Path
+  class Remote
     attr_accessor :name, :url, :fetch_opts
 
     def initialize(base, name)
diff --git a/lib/git/worktree.rb b/lib/git/worktree.rb
@@ -3,7 +3,7 @@
 require 'git/path'
 
 module Git
-  class Worktree < Path
+  class Worktree
     attr_accessor :full, :dir
 
     def initialize(base, dir, gcommit = nil)
