fix: fix Rubocop Naming/PredicateMethod offense

jcouball · jcouball · commit d33f7a8969ef · 2025-07-03T16:10:33.000-07:00
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -6,15 +6,6 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 5
-# Configuration parameters: Mode, AllowedMethods, AllowedPatterns, AllowBangMethods.
-# AllowedMethods: call
-Naming/PredicateMethod:
-  Exclude:
-    - 'lib/git/branch.rb'
-    - 'lib/git/lib.rb'
-    - 'tests/units/test_command_line.rb'
-
 # Offense count: 3
 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros, UseSorbetSigs.
 # NamePrefix: is_, has_, have_, does_
diff --git a/lib/git/branch.rb b/lib/git/branch.rb
@@ -56,8 +56,8 @@ def delete
       @base.lib.branch_delete(@name)
     end
 
-    def current
-      determine_current
+    def current # rubocop:disable Naming/PredicateMethod
+      @base.lib.branch_current == @name
     end
 
     def contains?(commit)
@@ -139,9 +139,5 @@ def check_if_create
     rescue StandardError
       nil
     end
-
-    def determine_current
-      @base.lib.branch_current == @name
-    end
   end
 end
diff --git a/lib/git/lib.rb b/lib/git/lib.rb
@@ -1512,7 +1512,9 @@ def meets_required_version?
       (current_command_version <=> required_command_version) >= 0
     end
 
-    def self.warn_if_old_command(lib)
+    def self.warn_if_old_command(lib) # rubocop:disable Naming/PredicateMethod
+      Git::Deprecation.warn('Git::Lib#warn_if_old_command is deprecated. Use meets_required_version?.')
+
       return true if @version_checked
 
       @version_checked = true
diff --git a/tests/units/test_command_line.rb b/tests/units/test_command_line.rb
@@ -42,15 +42,15 @@ def err_writer
     nil
   end
 
-  def normalize
+  def normalize # rubocop:disable Naming/PredicateMethod
     false
   end
 
-  def chomp
+  def chomp # rubocop:disable Naming/PredicateMethod
     false
   end
 
-  def merge
+  def merge # rubocop:disable Naming/PredicateMethod
     false
   end
 
