fix: fix Rubocop Lint/UselessConstantScoping offense

jcouball · jcouball · commit 54c4a3bba206 · 2025-07-03T16:10:33.000-07:00
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -6,11 +6,6 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
-Lint/UselessConstantScoping:
-  Exclude:
-    - 'lib/git/branch.rb'
-
 # Offense count: 68
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
diff --git a/lib/git/branch.rb b/lib/git/branch.rb
@@ -93,18 +93,6 @@ def to_s
       @full
     end
 
-    private
-
-    def check_if_create
-      @base.lib.branch_new(@name)
-    rescue StandardError
-      nil
-    end
-
-    def determine_current
-      @base.lib.branch_current == @name
-    end
-
     BRANCH_NAME_REGEXP = %r{
       ^
         # Optional 'refs/remotes/' at the beggining to specify a remote tracking branch
@@ -116,6 +104,8 @@ def determine_current
       $
     }x
 
+    private
+
     # Given a full branch name return an Array containing the remote and branch names.
     #
     # Removes 'remotes' from the beggining of the name (if present).
@@ -143,5 +133,15 @@ def parse_name(name)
       branch_name = match[:branch_name]
       [remote, branch_name]
     end
+
+    def check_if_create
+      @base.lib.branch_new(@name)
+    rescue StandardError
+      nil
+    end
+
+    def determine_current
+      @base.lib.branch_current == @name
+    end
   end
 end
